Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some instrumentations are missing the instrumentation dependency #359

Closed
ocelotl opened this issue Mar 3, 2021 · 0 comments · Fixed by #360
Closed

Some instrumentations are missing the instrumentation dependency #359

ocelotl opened this issue Mar 3, 2021 · 0 comments · Fixed by #360
Assignees
Labels
bug Something isn't working

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Mar 3, 2021

Some instrumentations are missing the opentelemetry-instrumentation dependency even when they use it directly in their source code. Fix this.

Just for the record, let's consider this situation (which is the situation of some instrumentations):

  1. Package A uses X in their code
  2. Package A has B as a dependency
  3. Package B has X as a dependency

This may seem like it is not necessary that package A has X specified in its dependencies because when installing A, B will be installed and before installing B, X will. Nevertheless, this is prone to breaking because if for some reason B changes and no longer depends on X, then A will break. Every package used in the source code of Z must be in the dependencies of Z.

@ocelotl ocelotl added the bug Something isn't working label Mar 3, 2021
@ocelotl ocelotl self-assigned this Mar 3, 2021
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Mar 3, 2021
@ocelotl ocelotl mentioned this issue Mar 3, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant