Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django's http_server_active_requests guage has wrong description #2513

Open
dkliban opened this issue May 10, 2024 · 0 comments
Open

Django's http_server_active_requests guage has wrong description #2513

dkliban opened this issue May 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dkliban
Copy link

dkliban commented May 10, 2024

I am seeing the following error in my collector when prometheus retrieves /metrics API:

net/http/server.go:2039
2024-05-10T00:53:49.988Z error [email protected]/log.go:23 error gathering metrics: 16 error(s) occurred:
* collected metric pulp_http_server_active_requests label:{name:"http_flavor" value:"1.1"} label:{name:"http_host" value:"pulp-api-svc.pulp-stage.svc.cluster.local:24817"} label:{name:"http_method" value:"PATCH"} label:{name:"http_scheme" value:"http"} label:{name:"http_server_name" value:"::"} label:{name:"job" value:"pulp-api"} gauge:{value:0} has help "measures the number of concurrent HTTP requests that are currently in-flight" but should have "measures the number of concurrent HTTP requests those are currently in flight"
* collected metric pulp_http_server_active_requests label:{name:"http_flavor" value:"1.1"} label:{name:"http_host" value:"10.129.2.18:24817"} label:{name:"http_method" value:"GET"} label:{name:"http_scheme" value:"http"} label:{name:"http_server_name" value:"::"} label:{name:"job" value:"pulp-api"} gauge:{value:0} has help "measures the number of concurrent HTTP requests that are currently in-flight" but should have "measures the number of concurrent HTTP requests those are currently in flight"

I believe the help text here[0] and here[1] needs to be updated to match the rest of the MetricInstruments.HTTP_SERVER_ACTIVE_REQUESTS instruments[2].

[0]

description="measures the number of concurrent HTTP requests those are currently in flight",

[1]
description="measures the number of concurrent HTTP requests those are currently in flight",

[2]

@dkliban dkliban added the bug Something isn't working label May 10, 2024
dkliban added a commit to dkliban/opentelemetry-python-contrib that referenced this issue May 10, 2024
dkliban added a commit to dkliban/pulp-service that referenced this issue May 10, 2024
dkliban added a commit to dkliban/pulp-service that referenced this issue May 10, 2024
dkliban added a commit to dkliban/pulp-service that referenced this issue May 10, 2024
dkliban added a commit to dkliban/pulp-service that referenced this issue May 10, 2024
dkliban added a commit to dkliban/pulp-service that referenced this issue May 10, 2024
dkliban added a commit to pulp/pulp-service that referenced this issue May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant