Upgrade proto to v1.4.0

[florianl]

Release of the v1.4.0 version of the OTLP.

[pellared]

I have a feeling that a newer version of Go is needed because of go-grpc dependency:

opentelemetry-proto-go/otlp/go.mod

Line 3 in 53bebda

go 1.17

See #194 (comment)

[florianl]

I have a feeling that a newer version of Go is needed because of go-grpc dependency:

@pellared this proposed change does not touch dependencies. There is no change in go.mod or go.sum. Can you provide more details, why the Go version should be bumped here?

[pellared]

I think it is a bug that should be fixed before the release.

[florianl]

I'm not sure and can't follow how this is related to this PR. From checking the PR again, I didn't identify an element, that would require a Go version bump.
Is there something in the current code base, that would require a Go version bump, was missed and is unrelated to this PR?

[pellared]

I'm not sure and can't follow how this is related to this PR. From checking the PR again, I didn't identify an element, that would require a Go version bump. Is there something in the current code base, that would require a Go version bump, was missed and is unrelated to this PR?

I created a bug:

• Improper version of go in go.mod #195

[florianl]

The following error sounds like a circular dependency issue resulting from multiple go.mod files:

go: finding module for package go.opentelemetry.io/proto/slim/otlp/profiles/v1development
go: go.opentelemetry.io/proto/gen/go/go.opentelemetry.io/proto/slim/otlp/collector/profiles/v1development imports
	go.opentelemetry.io/proto/slim/otlp/profiles/v1development: module go.opentelemetry.io/proto/slim/otlp@latest found (v1.3.1), but does not contain package go.opentelemetry.io/proto/slim/otlp/profiles/v1development
make: *** [Makefile:169: go-mod-tidy/.] Error 1

[dmathieu]

From the CI output, it looks like go-mod-tidy still doesn't remove the gen folder, which is weird as it works fine both on my mac and on a debian VM.

[pellared]

You should not generate slim/otlp/collector/profiles/v1development. slim modules should not have collector directory which brings the grpc dependency.

I wonder how was it even generated...

[florianl]

You should not generate slim/otlp/collector/profiles/v1development. slim modules should not have collector directory which brings the grpc dependency.

I wonder how was it even generated...

Can you provide more background on this? the Makefile target gen-otlp-protobuf-slim does not differentiate between collector and other parts.

opentelemetry-proto-go/Makefile

Lines 135 to 139 in f83a33f

	.PHONY: gen-otlp-protobuf-slim
	gen-otlp-protobuf-slim: $(SOURCE_PROTOSLIM_FILES)
	rm -rf ./$(PROTOBUF_TEMP_DIR)
	mkdir -p ./$(PROTOBUF_TEMP_DIR)
	$(foreach file,$(SOURCE_PROTOSLIM_FILES),$(call exec-command,$(PROTOC_SLIM) $(PROTO_INCLUDES) --go_out=./$(PROTOBUF_TEMP_DIR) $(file)))

While in the target gen-otlp-protobuf for every signal also a collector part is generated:
https://github.com/open-telemetry/opentelemetry-proto-go/blob/f83a33f5490808194d466cc3ff18c6e66a48a407/Makefile#L118C9-L126

[florianl]

I can reproduce the issue (see https://github.com/florianl/opentelemetry-proto-go/tree/release-v1.4.0-try-2) with a clean state on main and following the release process:

# update Makefile and repalce experimental with development
make sync VERSION=v1.4.0
# update versions.yaml from 1.3.1 to 1.4.0
make verify-versions
git diff

It is in all cases the combination of make clean protobuf go-mod-tidy ( as executed in CI), that breaks something.

[pellared]

Can you provide more background on this?

See: #155

Maybe I did some mistake(s). I am not a make expert.

[pellared]

@florianl, @dmathieu, good work 👍

[MikeGoldsmith]

Thanks @florianl