-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and test supported versions of Go #205
Conversation
I'm pondering adding a compatibility statement similar to the otel-go one. We don't really publish new releases with new Go versions though, and since this code is fully auto-generated, this may be a bit too much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should have compatibility tests for all supported versions of Go (currently 1.22 and 1.23). These tests can be run on Ubuntu runner as there is no OS-specific code.
Right now there is nothing that checks if the generated code actually builds.
Co-authored-by: Robert Pająk <[email protected]>
Once this is merged, I will make the |
I think you can do it even before merging 😉 |
It would prevent any other PR from being merged before this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong. go.sum
files should not be empty.
Their size has vastly reduced. They are not empty though. |
Fixes #195