Cross namespace instrumentation #889
Conversation
|
This looks sensible as an idea. Over in #886 (comment) I pointed out how some other services like Istio do it, using an |
There was a problem hiding this comment.
Thanks for this PR! @tKe
LGTM!
@pavolloffay can you review this PR from your end? :)
| @@ -118,8 +118,15 @@ func (pm *instPodMutator) getInstrumentationInstance(ctx context.Context, ns cor | |||
| return pm.selectInstrumentationInstanceFromNamespace(ctx, ns) | |||
| } | |||
|
|
|||
| var instNamespacedName types.NamespacedName | |||
There was a problem hiding this comment.
@tKe given we are changing the pod mutator that is used by the sidecar injection as well then the cross-namespace feature should work for the sidecar injector as well and we should document it. Would you like to submit a separate PR to document it for the sidecar?
There was a problem hiding this comment.
This pod mutator is only used for instrumentation. The sidecar injection uses a separate pod mutator which is not impacted. The sidecar injection cannot currently work across namespaces due to the requirement to mount the collector configmap.
|
I love PRs where the This is an exciting change to have. I was about to hack up my infrastructure to add a complicated mess of Kustomize |
* support cross-namespace instrumentation reference * update readme
This PR adds support for specifying the namespace of an instrumentation instance in the
inject-*annotations.closes #886