Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collector CRD for kube 1.22 #521

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

rkukura
Copy link
Contributor

@rkukura rkukura commented Nov 9, 2021

Signed-off-by: Robert Kukura [email protected]

@rkukura rkukura requested review from a team and owais November 9, 2021 23:24
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 9, 2021

CLA Signed

The committers are authorized under a signed CLA.

@pavolloffay
Copy link
Member

@rkukura please sign the CLA

@VineethReddy02
Copy link
Contributor

Fixes: #473

Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkukura thanks for the PR.

Can you please sign the CLA & address the comment from Pavol?

@rkukura
Copy link
Contributor Author

rkukura commented Nov 10, 2021

@rkukura thanks for the PR.

Can you please sign the CLA & address the comment from Pavol?

Should be all set.

Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VineethReddy02 VineethReddy02 merged commit bfe8637 into open-telemetry:main Nov 10, 2021
@rkukura rkukura deleted the fix-crd branch November 10, 2021 17:45
rkukura pushed a commit to rkukura/community-operators-prod that referenced this pull request Nov 10, 2021
This commit is based on
https://github.com/open-telemetry/opentelemetry-operator/releases/tag/v0.38.0
but incorporates the fixed CRD from
open-telemetry/opentelemetry-operator#521
needed to work on OpenShift 4.9.

Signed-off-by: Robert Kukura <[email protected]>
rkukura pushed a commit to rkukura/community-operators that referenced this pull request Nov 11, 2021
This commit is based on
https://github.com/open-telemetry/opentelemetry-operator/releases/tag/v0.38.0
but incorporates the fixed CRD from
open-telemetry/opentelemetry-operator#521
needed to work on Kubernetes 1.22.

Signed-off-by: Robert Kukura <[email protected]>
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
Fix collector CRD for kube 1.22 

Signed-off-by: Robert Kukura <[email protected]>
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Fix collector CRD for kube 1.22 

Signed-off-by: Robert Kukura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants