Migrate to use new parsers #3069
Conversation
apis/v1beta1/config.go
Outdated
| @@ -133,6 +139,53 @@ type Config struct { | |||
| Service Service `json:"service" yaml:"service"` | |||
| } | |||
|
|
|||
| // getPortsForComponentTypes gets the ports for the given ComponentType(s). | |||
| // NOTE FOR REVIEWERS: we could also do this by introducing something in components that is aware of which retriever | |||
There was a problem hiding this comment.
Seeking opinions here
There was a problem hiding this comment.
I guess this depends on where we want to handle finding the right component config. At this level, we know it exists, as we're iterating over the map. The retriever would have to check and potentially return an error. Is there any other place we need this logic in? If it's just here, I'd keep it as is.
| @@ -37,105 +25,3 @@ const ( | |||
| func (c ComponentType) String() string { | |||
There was a problem hiding this comment.
this will be deleted in a followup!
apis/v1beta1/config.go
Outdated
| @@ -133,6 +139,53 @@ type Config struct { | |||
| Service Service `json:"service" yaml:"service"` | |||
| } | |||
|
|
|||
| // getPortsForComponentTypes gets the ports for the given ComponentType(s). | |||
| // NOTE FOR REVIEWERS: we could also do this by introducing something in components that is aware of which retriever | |||
There was a problem hiding this comment.
I guess this depends on where we want to handle finding the right component config. At this level, we know it exists, as we're iterating over the map. The retriever would have to check and potentially return an error. Is there any other place we need this logic in? If it's just here, I'd keep it as is.
| ) | ||
|
|
||
| type ComponentType int | ||
| type ComponentKind int |
There was a problem hiding this comment.
I am just curious why kind?
There was a problem hiding this comment.
this was per @swiatekm-sumo comment here #3069 (comment)
|
@jaronoff97 it is approved, can we merge it? |
Description: Enables the operator to use the new parsers
Link to tracking Issue(s):
Testing: Unit tests
Documentation: