Remove unnecessary config marshalling in v1beta1

[pavolloffay]

Component(s)

collector

Describe the issue you're reporting

Created from #2532

[crossoverJie]

@pavolloffay
I'd like to fix this issue.

We can create a hardcoded method:

func (c *Config) ToMap() map[string]interface{} {
	result := make(map[string]interface{})

	result["receivers"] = c.Receivers.Object
	result["exporters"] = c.Exporters.Object
	if c.Processors != nil {
		result["processors"] = c.Processors.Object
	}

	if c.Connectors != nil {
		result["connectors"] = c.Connectors.Object
	}
	if c.Extensions != nil {
		result["extensions"] = c.Extensions.Object

	}
	serviceMap := make(map[string]interface{})
	if c.Service.Extensions != nil {
		serviceMap["extensions"] = c.Service.Extensions
	}
	if c.Service.Telemetry != nil {
		serviceMap["telemetry"] = c.Service.Telemetry
	}
	serviceMap["pipelines"] = c.Service.Pipelines.Object
	result["service"] = serviceMap

	return result
}

Or use serialization method:

func (c *Config) ToMap() (map[string]interface{}, error) {
	var result map[string]interface{}
	v, err := json.Marshal(c)
	if err != nil {
		return nil, err
	}
	err = json.Unmarshal(v, &result)
	if err != nil {
		return nil, err
	}
	return result, err
}

But this will still cause multiple calls to the serialization and deserialization method.

BWT, maybe we can replace map[interface{}]interface{} with map[string]interface{} so we can avoid redundant type assertions.

opentelemetry-operator/internal/manifests/collector/adapters/config_validate.go

Line 68 in e58df33

pipelineV, withPipelineCfg := pipelineID.(string)

[jaronoff97]

@crossoverJie yep, already working on this :)

[pavolloffay]

@jaronoff97 is this done?

[jaronoff97]

Almost! We still have this code block that we should probably try and fix