Update file watcher to detect file write event #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We intend to deprecate the file watcher sooner rather than later as per #2032. I can still accept this PR, but I wanted to let you know in case you don't want to continue working on it. |
Thanks so much for letting me know @swiatekm-sumo! I can merge this PR now, so that it has the fix until it is fully deprecated with the newer version. |
swiatekm
approved these changes
Nov 15, 2023
|
@swiatekm-sumo - I dont have permissions to merge this, could you please merge this PR? |
jaronoff97
approved these changes
Nov 15, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* adding file write event * adding issue link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing a bug - Update file watcher to detect file write events along with file create event for targetallocator
Testing: Tested that all file events get picked up.