Skip to content

Commit

Permalink
Update file watcher to detect file write event (open-telemetry#2334)
Browse files Browse the repository at this point in the history
* adding file write event

* adding issue link
  • Loading branch information
rashmichandrashekar authored Nov 15, 2023
1 parent 7add57c commit d22ca43
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
16 changes: 16 additions & 0 deletions .chloggen/target-allocator-file-watch.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
component: target allocator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Update file watcher to detect file write events

# One or more tracking issues related to the change
issues: [2349]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
4 changes: 3 additions & 1 deletion cmd/otel-allocator/watcher/file.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ func (f *FileWatcher) Watch(upstreamEvents chan Event, upstreamErrors chan error
case <-f.closer:
return nil
case fileEvent := <-f.watcher.Events:
if fileEvent.Op == fsnotify.Create {
// Using Op.Has as per this doc - https://github.com/fsnotify/fsnotify/blob/9342b6df577910c6eac718dc62845d8c95f8548b/fsnotify.go#L30
if fileEvent.Op.Has(fsnotify.Create) || fileEvent.Op.Has(fsnotify.Write) {
f.logger.Info("File change detected", "event", fileEvent.Op.String())
upstreamEvents <- Event{
Source: EventSourceConfigMap,
Watcher: Watcher(f),
Expand Down

0 comments on commit d22ca43

Please sign in to comment.