fix: collector selection should not fail if there is a single sidecar #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes open-telemetry#200 if there are multiple collectors, but a single sidecar, the collector selection should not fail. this fix ensure we filter the list of collectors first. Signed-off-by: Vincent Behar <[email protected]>
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
…open-telemetry#210) fixes open-telemetry#200 if there are multiple collectors, but a single sidecar, the collector selection should not fail. this fix ensure we filter the list of collectors first. Signed-off-by: Vincent Behar <[email protected]>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…open-telemetry#210) fixes open-telemetry#200 if there are multiple collectors, but a single sidecar, the collector selection should not fail. this fix ensure we filter the list of collectors first. Signed-off-by: Vincent Behar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #200
if there are multiple collectors, but a single sidecar, the collector selection should not fail.
this fix ensures we filter the list of collectors first.
Signed-off-by: Vincent Behar [email protected]