Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Injection when annotation=true fails when if there are other instances but only one in sidecar mode. #200

Closed
rubenvp8510 opened this issue Feb 15, 2021 · 0 comments · Fixed by #210
Closed

Injection when annotation=true fails when if there are other instances but only one in sidecar mode. #200

rubenvp8510 opened this issue Feb 15, 2021 · 0 comments · Fixed by #210

Comments

@rubenvp8510
Copy link
Contributor

rubenvp8510 commented Feb 15, 2021 •
edited
Loading

Side injection when sidecar.opentelemetry.io/inject: true doesn't work when there are other opentelemetry collectors but only one in sidecar mode.

Failed with the following message:

Failed to select an OpenTelemetry Collector instance for this pod's sidecar","namespace":"","name":"","error":"multiple OpenTelemetry Collector instances available, cannot determine which one to select

It is true that there are other opentelemetry collector instances, but should not fail if there is only one instance with mode:sidecar.
vbehar added a commit to vbehar/opentelemetry-operator that referenced this issue Feb 19, 2021
@vbehar
fix: collector selection should not fail if there is a single sidecar
5501f26 
fixes open-telemetry#200

if there are multiple collectors, but a single sidecar, the collector selection should not fail.
this fix ensure we filter the list of collectors first.

Signed-off-by: Vincent Behar <[email protected]>
@vbehar vbehar mentioned this issue Feb 19, 2021
Merged
jpkrohling pushed a commit that referenced this issue Feb 23, 2021
@vbehar
fix: collector selection should not fail if there is a single sidecar (…
a13ca07 
…#210)

fixes #200

if there are multiple collectors, but a single sidecar, the collector selection should not fail.
this fix ensure we filter the list of collectors first.

Signed-off-by: Vincent Behar <[email protected]>
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this issue Dec 12, 2021
@vbehar
fix: collector selection should not fail if there is a single sidecar (…
394da6d 
…open-telemetry#210)

fixes open-telemetry#200

if there are multiple collectors, but a single sidecar, the collector selection should not fail.
this fix ensure we filter the list of collectors first.

Signed-off-by: Vincent Behar <[email protected]>
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this issue May 1, 2024
@vbehar
fix: collector selection should not fail if there is a single sidecar (…
2e2f359 
…open-telemetry#210)

fixes open-telemetry#200

if there are multiple collectors, but a single sidecar, the collector selection should not fail.
this fix ensure we filter the list of collectors first.

Signed-off-by: Vincent Behar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: collector selection should not fail if there is a single sidecar vbehar/opentelemetry-operator
1 participant
@rubenvp8510