Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.4.0 release proposal #751

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Jan 29, 2020

Which problem is this PR solving?

@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #751 into master will increase coverage by 3.83%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   89.49%   93.33%   +3.83%     
==========================================
  Files         153       32     -121     
  Lines        5188      675    -4513     
  Branches      442       54     -388     
==========================================
- Hits         4643      630    -4013     
+ Misses        545       45     -500
Impacted Files Coverage Δ
packages/opentelemetry-api/src/version.ts 0% <0%> (ø) ⬆️
...ges/opentelemetry-propagator-jaeger/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-scope-base/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-base/src/version.ts 0% <0%> (ø) ⬆️
...ckages/opentelemetry-plugin-mongodb/src/version.ts 100% <100%> (ø)
...y-api/test/noop-implementations/noop-meter.test.ts 97.22% <0%> (ø) ⬆️
...-api/src/context/propagation/NoopHttpTextFormat.ts 100% <0%> (ø) ⬆️
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø) ⬆️
...telemetry-scope-base/test/NoopScopeManager.test.ts 100% <0%> (ø) ⬆️
...opentelemetry-api/src/metrics/NoopMeterProvider.ts 100% <0%> (ø) ⬆️
... and 126 more

@dyladan
Copy link
Member

dyladan commented Jan 29, 2020

Did you intentionally not update examples/getting started?

@mayurkale22
Copy link
Member Author

Did you intentionally not update examples/getting started?

Yes, we can update that after the release.

@dyladan
Copy link
Member

dyladan commented Jan 29, 2020

holding the approval until #749 is merged and included in this but overall LGTM

@OlivierAlbertini OlivierAlbertini added API Dependency on other PR This PR can't be merged because it has dependency on other PRs labels Jan 30, 2020
@OlivierAlbertini
Copy link
Member

to merge after #747

@OlivierAlbertini OlivierAlbertini added needs-more-reviewers PRs with this label are ready for review and needs more people to review to move forward. and removed Dependency on other PR This PR can't be merged because it has dependency on other PRs Awaiting reviewer feedback labels Jan 30, 2020
@OlivierAlbertini
Copy link
Member

Should we wait for

?

#628 would also add breaking changes.

@mayurkale22
Copy link
Member Author

Yes, I am waiting for #749. I am not sure about the current state of #628 /cc @dyladan

@dyladan
Copy link
Member

dyladan commented Jan 30, 2020

Yes wait for #749

#628 should probably be closed. there is some talk in specs about making configuration mechanisms standardized across SIGs.

@mayurkale22
Copy link
Member Author

holding the approval until #749 is merged and included in this but overall LGTM

@dyladan #749 merged into master, please review this PR.

@obecny
Copy link
Member

obecny commented Feb 4, 2020

this should not be released - all examples doesn't work because of api changes

@mayurkale22
Copy link
Member Author

this should not be released - all examples doesn't work because of api changes

Waiting on #750

@dyladan dyladan mentioned this pull request Feb 4, 2020
@mayurkale22 mayurkale22 force-pushed the draft_0.4.0 branch 2 times, most recently from 8ea7a74 to 053aa73 Compare February 5, 2020 19:06
@dyladan
Copy link
Member

dyladan commented Feb 5, 2020

Think this is good to go 🚀

@obecny
Copy link
Member

obecny commented Feb 5, 2020

#761 yet before that

@obecny
Copy link
Member

obecny commented Feb 5, 2020

Few questions with regards to

  1. examples
  2. getting started (versioning and still using registry instead of provider).
  3. might be not related to this but do we already have "MeterProvider" instead of "MeterRegistry" ?

@mayurkale22
Copy link
Member Author

Few questions with regards to ...

I think we have updated all the places (examples, getting-started etc.) to use latest code changes as per the master branch. I will update the examples version after the release.

@mayurkale22 mayurkale22 removed the needs-more-reviewers PRs with this label are ready for review and needs more people to review to move forward. label Feb 5, 2020
@mayurkale22 mayurkale22 self-assigned this Feb 5, 2020
@mayurkale22 mayurkale22 merged commit 0d52bf5 into open-telemetry:master Feb 5, 2020
@mayurkale22 mayurkale22 deleted the draft_0.4.0 branch February 5, 2020 23:00
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
* chore: 0.4.0 release proposal

* use api instead of types
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* chore: 0.4.0 release proposal

* use api instead of types
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants