Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename registry to provider #749

Merged
merged 3 commits into from
Feb 3, 2020
Merged

chore: rename registry to provider #749

merged 3 commits into from
Feb 3, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 29, 2020

Fixes #740

@dyladan dyladan mentioned this pull request Jan 29, 2020
Closed
@mayurkale22 mayurkale22 mentioned this pull request Jan 29, 2020
Merged
mayurkale22
mayurkale22 approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

OlivierAlbertini
OlivierAlbertini approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierAlbertini OlivierAlbertini added Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) API enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files. Dependency on other PR This PR can't be merged because it has dependency on other PRs labels Jan 30, 2020
@OlivierAlbertini
Copy link
Member

to merge after #747

@OlivierAlbertini OlivierAlbertini added breaking and removed Dependency on other PR This PR can't be merged because it has dependency on other PRs labels Jan 30, 2020
@mayurkale22 mayurkale22 merged commit d2e96ba into open-telemetry:master Feb 3, 2020
@dyladan dyladan deleted the rename-provider-rebase branch February 3, 2020 18:38
@obecny
Copy link
Member

obecny commented Feb 4, 2020

You haven't updated examples

@dyladan
Copy link
Member Author

dyladan commented Feb 4, 2020

That was intentional, to make the PR a little smaller and easier to review. That change is here #750

@obecny
Copy link
Member

obecny commented Feb 4, 2020

the examples in master won't work for development now :/

dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@dyladan
chore: rename registry to provider (open-telemetry#749)
9469ef7 
* chore: rename registry to provider

* chore: revert changelog modification

* chore: remove examples and getting started from rename
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@dyladan
chore: rename registry to provider (open-telemetry#749)
3070228 
* chore: rename registry to provider

* chore: revert changelog modification

* chore: remove examples and getting started from rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@OlivierAlbertini OlivierAlbertini OlivierAlbertini approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@bg451 bg451 Awaiting requested review from bg451

@markwolff markwolff Awaiting requested review from markwolff

@obecny obecny Awaiting requested review from obecny

@rochdev rochdev Awaiting requested review from rochdev

Assignees
No one assigned
Labels
enhancement New feature or request Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Registry to Provider
5 participants
@dyladan @OlivierAlbertini @obecny @vmarchaud @mayurkale22