-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mysql support #525
feat: mysql support #525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
==========================================
+ Coverage 90.25% 92.44% +2.19%
==========================================
Files 148 157 +9
Lines 7448 7958 +510
Branches 668 689 +21
==========================================
+ Hits 6722 7357 +635
+ Misses 726 601 -125
|
@open-telemetry/javascript-approvers this is ready for reviews. pls take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the @ts-ignore
that i would prefer to remove, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@mayurkale22 should I add mysql to the default plugins list in this PR or should I wait until this is merged and do a separate PR? |
I am fine with either way. In the future, maybe will update the default plugins list once the plugin looks stable after 1-2 release. WDYT? |
Which problem is this PR solving?
This is a draft PR so that people can take a look and give feedback. It is not ready for merge and has not been sufficiently tested.There is an example atexamples/mysql
where you can see a working example.Basic description of changes
createConnection
createPool
edit: prepared statements not supported by
mysql
package