Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request(plugin): mysql #489

Closed
markwolff opened this issue Nov 5, 2019 · 9 comments
Closed

Request(plugin): mysql #489

markwolff opened this issue Nov 5, 2019 · 9 comments
Assignees
Milestone

Comments

@markwolff
Copy link
Member

markwolff commented Nov 5, 2019

Is your plugin request related to a problem? Please describe.
Add tracing to mysql query operations

Is it applicable for Node or Browser or both
Node

Do you expect this plugin to be commonly used
Weekly Downloads: ~500k + ~250k

What version of plugin are you interested in using
Node Versions: >=8

@mayurkale22 mayurkale22 added plugin-request up-for-grabs Good for taking. Extra help will be provided by maintainers and removed feature-request labels Nov 5, 2019
@mayurkale22
Copy link
Member

mysql and mysql2 (~243K Weekly Downloads) have very closely resembling public APIs, does it makes sense to combine them together ?

@dyladan
Copy link
Member

dyladan commented Nov 5, 2019

mysql and mysql2 (~243K Weekly Downloads) have very closely resembling public APIs, does it makes sense to combine them together ?

This is what dynatrace does. They actually have the same api. It is a stated goal of mysql2 to be API compatible with mysql

@dyladan
Copy link
Member

dyladan commented Nov 5, 2019

I am somewhat familiar with the api if you're looking for someone to take this

@markwolff markwolff removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 5, 2019
@markwolff
Copy link
Member Author

I am somewhat familiar with the api if you're looking for someone to take this

Assigned it to you. Let me know if this is an issue :)

@markwolff markwolff changed the title Request(plugin): mysql Request(plugin): mysql/mysql2 Nov 6, 2019
@mayurkale22 mayurkale22 modified the milestones: Alpha v0.4, Alpha v0.3 Nov 6, 2019
@dyladan dyladan mentioned this issue Nov 13, 2019
8 tasks
@mayurkale22
Copy link
Member

Can we close this one via #525?

@dyladan
Copy link
Member

dyladan commented Dec 2, 2019

@mayurkale22 mysql2 is still not covered. If you close it can you rename it to just request mysql and open a new one?

@mayurkale22
Copy link
Member

If you close it can you rename it to just request mysql and open a new one?

@markwolff do you agree with this?

@dyladan
Copy link
Member

dyladan commented Dec 2, 2019

I attempted to make the mysql one work with mysql2 but the internal implementation details were too different. There will be some shared code, but it wasn't as easy as i'd expected

@mayurkale22 mayurkale22 changed the title Request(plugin): mysql/mysql2 Request(plugin): mysql Dec 4, 2019
@mayurkale22
Copy link
Member

@mayurkale22 mysql2 is still not covered. If you close it can you rename it to just request mysql and open a new one?

I removed mysql2 from the title, let's close one and handle mysql2 instrumentation based on request.

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants