chore(deps): update webpack to latest #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4340 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 332 332
Lines 9447 9447
Branches 2003 2003
=======================================
Hits 8711 8711
Misses 736 736 |
dyladan
force-pushed
the
update-webpack
branch
from
8634b01
to
2617cb3
Compare
dyladan
force-pushed
the
update-webpack
branch
from
2617cb3
to
dfbd20f
Compare
dyladan
force-pushed
the
update-webpack
branch
from
dfbd20f
to
6f3c53f
Compare
legendecas
approved these changes
Dec 12, 2023
pichlermarc
changed the title
pichlermarc
approved these changes
Dec 12, 2023
legendecas
reviewed
Dec 13, 2023
pichlermarc
reviewed
Dec 13, 2023
There was a problem hiding this comment.
This is great 🙂
We can now also remove the renovate-bot dashboard approval requirement for webpack and webpack-cli (https://github.com/open-telemetry/opentelemetry-js/blame/4fe1ae8aaf39dc310f8fd242405a13e1456239db/renovate.json#L20)
legendecas
approved these changes
Dec 13, 2023
pichlermarc
approved these changes
Dec 13, 2023
rdeavila94
pushed a commit
to rdeavila94/opentelemetry-js
that referenced
this pull request
Jan 3, 2024
* Update webpack to latest * Skip tree shake test on node 8 * Update webpack utility modules * lint * Apply review comments * Invert test skip * Use process.versions.node * Remove approval requirement for webpack
1 task
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
* Update webpack to latest * Skip tree shake test on node 8 * Update webpack utility modules * lint * Apply review comments * Invert test skip * Use process.versions.node * Remove approval requirement for webpack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work fine. The only change that needed to be made was disabling the tree-shaking tests on node 8, which I think is a reasonable compromise.