-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for API 1.1.x #2737
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2737 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 159 159
Lines 5444 5444
Branches 1141 1142 +1
=======================================
Hits 5078 5078
Misses 366 366
|
Converting to draft until API release |
@open-telemetry/javascript-maintainers please review this ASAP as the API is already released and I want to release the SDK in a timely manner |
@@ -59,7 +59,7 @@ | |||
"typescript": "4.4.4" | |||
}, | |||
"peerDependencies": { | |||
"@opentelemetry/api": ">=1.0.0 <1.1.0" | |||
"@opentelemetry/api": ">=1.0.0 <1.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking one more about this now with #2755 (comment) in mind it seems to be not that good to allow more then one minor in SDK.
If SDK ends up in using 1.0.x because the de-duplication of package manager decide so but other components use 1.1.x these other components will have issues as the version check in API signals incompatibility.
I guess the SDK must use the highest minor.
Prepare a draft PR to get schemaUrl feature as quickly as possible after API release.
Depends on open-telemetry/opentelemetry-js-api#154