Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable package tests CI failure on Node.js v16 #2755

Closed
legendecas opened this issue Feb 2, 2022 · 2 comments · Fixed by #2759
Closed

Stable package tests CI failure on Node.js v16 #2755

legendecas opened this issue Feb 2, 2022 · 2 comments · Fixed by #2759
Labels
bug Something isn't working

Comments

@legendecas
Copy link
Member

CI is constantly failing on Node.js v16 for stable packages tests since ee2342b was merged.

@legendecas legendecas added the bug Something isn't working label Feb 2, 2022
@Flarna
Copy link
Member

Flarna commented Feb 2, 2022

I tried to take a look local but for me even npm install fails with

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/webpack
npm ERR!   webpack@"4.46.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^5.1.0" from [email protected]
npm ERR! node_modules/terser-webpack-plugin
npm ERR!   terser-webpack-plugin@"5.2.5" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@Flarna
Copy link
Member

Flarna commented Feb 2, 2022

I was able to reproduce this local. For whatever reason @opentelemetry/api v1.0.4 is installed as a dependency within sdk-trace-node which results in having two API versions (1.0.4 and 1.1.0) in build.

As the SDK has 1.0.4 and others have 1.1.0 the version check in API tells the 1.1.0 users (e.g. context-async-hooks) that it is incompatible.

I have no idea why 1.0.4 gets installed here as ranges should go for 1.1.0. But it seems this shows that allowing ranges from 1.0.0 to 1.2.0 is problematic as the version check in API may reject a newer minor version.

if I change the range in sdk-trace-node to ">=1.1.0 <1.2.0" the hosted 1.1.0 version of API is used and tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants