-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update webpack outside of examples #963
Conversation
Codecov Report
@@ Coverage Diff @@
## main #963 +/- ##
==========================================
- Coverage 95.91% 94.91% -1.00%
==========================================
Files 13 24 +11
Lines 856 1180 +324
Branches 178 236 +58
==========================================
+ Hits 821 1120 +299
- Misses 35 60 +25
|
I'm surpriesed that you got this running. A while ago I tried something similar in core repo but failed (created open-telemetry/opentelemetry-js#2187 that time). One of the reasons why I failed were that there are dependencies which seem to require webpack for, e.g. istanbul-instrumenter-loader has |
Those errors are ignored if legacy peer deps is turned on, so I guess that's why it hasn't popped onto my radar.
|
Even though |
Any additional comments/questions, @Flarna? |
No questions. Nice that this works. |
I think nobody is left who remembers when they were set up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe we can apply this to the main repo too?
I meant there are maybe others in reviewers/maintainers group who have a better understanding of browser tooling. If not browser support will most likely degrade more and more over time. |
Just linked this PR to a relevant issue for now, but I'll keep that in mind. |
This reverts commit 9a58648.
Which problem is this PR solving?
Webpack hasn't been updated for a while. Testing out
pnpm
, I noticed webpack@4 doesn't work with it at all, so out of curiousity(the research ofpnpm
is still ongoing) had to hack it to work.I'm not familiar with configuring webpack at all so any feedback to the changes are very welcome. The build results are identical.
Short description of the changes
karma.conf.js
to include all plugins form the relativepackage.json
- Karma failed autoloading all deps from the package.json if the deps were symlinked.Checklist
RanBrowser-based packages do not use TAVnpm run test-all-versions
for the edited package(s) on the latest commit if applicable.