Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix CI by forcing [email protected] #825

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Jan 10, 2022

Which problem is this PR solving?

colors a widely used terminal styling package is causing our CI to crash. Not sure when that will be fixed and how so meanwhile I'll add a dev dependency on [email protected] to force npm to install an older version.

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the npm overrides? Though it is only available on npm v8.3.0 and later.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #825 (6b7f550) into main (81b3190) will decrease coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   94.88%   94.38%   -0.50%     
==========================================
  Files          13       28      +15     
  Lines         684     1407     +723     
  Branches      138      152      +14     
==========================================
+ Hits          649     1328     +679     
- Misses         35       79      +44     
Impacted Files Coverage Δ
...metry-instrumentation-document-load/src/version.ts
...telemetry-instrumentation-long-task/src/version.ts
...entation-document-load/src/enums/AttributeNames.ts
...etry-plugin-react-load/src/enums/AttributeNames.ts
...y-instrumentation-long-task/src/instrumentation.ts
...strumentation-document-load/src/instrumentation.ts
...entelemetry-instrumentation-long-task/test/util.ts
...trumentation-document-load/src/enums/EventNames.ts
...lugin-react-load/src/BaseOpenTelemetryComponent.ts
...ation-user-interaction/src/enums/AttributeNames.ts
... and 31 more

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % the question about overrides

@rauno56
Copy link
Member Author

rauno56 commented Jan 10, 2022

Yeah, it doesn't help us on node <16 :(

@rauno56
Copy link
Member Author

rauno56 commented Jan 10, 2022

I'll merge this for now. It's definitely not a permanent solution.
#826

@rauno56 rauno56 merged commit 0ec9f08 into open-telemetry:main Jan 10, 2022
@rauno56 rauno56 deleted the fix/force-colors-1-4-0 branch January 11, 2022 09:44
@dyladan dyladan mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants