-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix CI by forcing [email protected] #825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the npm overrides? Though it is only available on npm v8.3.0 and later.
Codecov Report
@@ Coverage Diff @@
## main #825 +/- ##
==========================================
- Coverage 94.88% 94.38% -0.50%
==========================================
Files 13 28 +15
Lines 684 1407 +723
Branches 138 152 +14
==========================================
+ Hits 649 1328 +679
- Misses 35 79 +44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % the question about overrides
Yeah, it doesn't help us on node <16 :( |
I'll merge this for now. It's definitely not a permanent solution. |
Which problem is this PR solving?
colors
a widely used terminal styling package is causing our CI to crash. Not sure when that will be fixed and how so meanwhile I'll add a dev dependency on [email protected] to force npm to install an older version.