Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #825: colors terminal DOS #826

Closed
rauno56 opened this issue Jan 10, 2022 · 6 comments · Fixed by #943 or #947
Closed

Revert #825: colors terminal DOS #826

rauno56 opened this issue Jan 10, 2022 · 6 comments · Fixed by #943 or #947

Comments

@rauno56
Copy link
Member

rauno56 commented Jan 10, 2022

To avoid people running into problems with broken colors package, I added [email protected] to package.json, that needs to be reverted when the situation with the colors package is resolved.

@dyladan
Copy link
Member

dyladan commented Jan 10, 2022

Tracking issue in colorsjs repo: Marak/colors.js#285

@vmarchaud
Copy link
Member

After reading a bunch on reddit it seems that the author will not fix the package anytime soon

@dyladan
Copy link
Member

dyladan commented Jan 10, 2022

Could be also that karma removes the dependency on colors

@dyladan
Copy link
Member

dyladan commented Jan 10, 2022

They may also switch to the fork by one of the colors maintainers https://github.com/DABH/colors.js

@rauno56
Copy link
Member Author

rauno56 commented Jan 11, 2022

Tracking issue in colorsjs repo: Marak/colors.js#285

That tracking issue is a joke. It's malicious activity by the maintainer. We depend on the colors through Karma - they need to fix before we can act on this issue.

@Flarna
Copy link
Member

Flarna commented Jan 11, 2022

Seems npm removed colors >1.4.0 meanwhile. Not sure if this should be the trigger to revert.

rauno56 added a commit to rauno56/opentelemetry-js-contrib that referenced this issue Mar 14, 2022
rauno56 added a commit that referenced this issue Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants