Fix direct record methods on instrument to call unbind. #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Cristian Drutu <[email protected]>
bogdandrutu
requested review from
arminru,
carlosalberto,
jkwatson,
pavolloffay,
songy23 and
tylerbenson
as code owners
jkwatson
reviewed
Feb 7, 2020
| bind(labelSet).add(delta); | ||
| BoundDoubleCounter boundDoubleCounter = bind(labelSet); | ||
| boundDoubleCounter.add(delta); | ||
| boundDoubleCounter.unbind(); |
There was a problem hiding this comment.
Just thinking out loud...what would you think about having add return this so you could just write:
bind(labelSet).add(delta).unbind();
in one fluent call?
There was a problem hiding this comment.
I thought about this, but it is not that useful for users using bounds, but probably doesn't hurt. Happy to accept a followup PR to see how would look like:)
There was a problem hiding this comment.
yeah, I agree. The bytecode probably ends up looking identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.