Fix direct record methods on instrument to call unbind. (#836)

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
open-telemetry · Feb 7, 2020 · a9a31a0 · a9a31a0
1 parent e7be014
commit a9a31a0
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/DoubleCounterSdk.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/DoubleCounterSdk.java
@@ -38,7 +38,9 @@ private DoubleCounterSdk(
 
   @Override
   public void add(double delta, LabelSet labelSet) {
-    bind(labelSet).add(delta);
+    BoundDoubleCounter boundDoubleCounter = bind(labelSet);
+    boundDoubleCounter.add(delta);
+    boundDoubleCounter.unbind();
   }
 
   @Override

diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/DoubleMeasureSdk.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/DoubleMeasureSdk.java
@@ -38,7 +38,9 @@ private DoubleMeasureSdk(
 
   @Override
   public void record(double value, LabelSet labelSet) {
-    bind(labelSet).record(value);
+    BoundDoubleMeasure boundDoubleMeasure = bind(labelSet);
+    boundDoubleMeasure.record(value);
+    boundDoubleMeasure.unbind();
   }
 
   @Override

diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/LongCounterSdk.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/LongCounterSdk.java
@@ -38,7 +38,9 @@ private LongCounterSdk(
 
   @Override
   public void add(long delta, LabelSet labelSet) {
-    bind(labelSet).add(delta);
+    BoundLongCounter boundLongCounter = bind(labelSet);
+    boundLongCounter.add(delta);
+    boundLongCounter.unbind();
   }
 
   @Override

diff --git a/sdk/src/main/java/io/opentelemetry/sdk/metrics/LongMeasureSdk.java b/sdk/src/main/java/io/opentelemetry/sdk/metrics/LongMeasureSdk.java
@@ -38,7 +38,9 @@ private LongMeasureSdk(
 
   @Override
   public void record(long value, LabelSet labelSet) {
-    bind(labelSet).record(value);
+    BoundLongMeasure boundLongMeasure = bind(labelSet);
+    boundLongMeasure.record(value);
+    boundLongMeasure.unbind();
   }
 
   @Override