Rename Setter.put to Setter.set #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
pavolloffay and
songy23
as code owners
carlosalberto
approved these changes
Jan 17, 2020
tylerbenson
force-pushed
the
tyer/setter
branch
from
ea67923 to
d03ae12
Compare
Improving consistency and cohesion of naming.
tylerbenson
force-pushed
the
tyer/setter
branch
from
d03ae12 to
7c7d8af
Compare
|
@carlosalberto any reason not to merge? |
|
Sorry for the build errors. I missed a few changes because my IDE wasn't configured correctly. Build is green now. |
bogdandrutu
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving consistency and cohesion of naming.
Fixes #762