Rename Setter.put to Setter.set (#769)

Improving consistency and cohesion of naming.
open-telemetry · Jan 17, 2020 · 7b601b1 · 7b601b1
1 parent ba17e1f
commit 7b601b1
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/api/src/main/java/io/opentelemetry/context/propagation/HttpTextFormat.java b/api/src/main/java/io/opentelemetry/context/propagation/HttpTextFormat.java
@@ -82,7 +82,7 @@ interface Setter<C> {
      * @param value the value of the field.
      * @since 0.1.0
      */
-    void put(C carrier, String key, String value);
+    void set(C carrier, String key, String value);
   }
 
   /**

diff --git a/api/src/main/java/io/opentelemetry/trace/propagation/HttpTraceContext.java b/api/src/main/java/io/opentelemetry/trace/propagation/HttpTraceContext.java
@@ -82,7 +82,7 @@ public <C> void inject(SpanContext spanContext, C carrier, Setter<C> setter) {
     spanContext.getSpanId().copyLowerBase16To(chars, SPAN_ID_OFFSET);
     chars[TRACE_OPTION_OFFSET - 1] = TRACEPARENT_DELIMITER;
     spanContext.getTraceFlags().copyLowerBase16To(chars, TRACE_OPTION_OFFSET);
-    setter.put(carrier, TRACEPARENT, new String(chars));
+    setter.set(carrier, TRACEPARENT, new String(chars));
     List<Tracestate.Entry> entries = spanContext.getTracestate().getEntries();
     if (entries.isEmpty()) {
       // No need to add an empty "tracestate" header.
@@ -98,7 +98,7 @@ public <C> void inject(SpanContext spanContext, C carrier, Setter<C> setter) {
           .append(TRACESTATE_KEY_VALUE_DELIMITER)
           .append(entry.getValue());
     }
-    setter.put(carrier, TRACESTATE, stringBuilder.toString());
+    setter.set(carrier, TRACESTATE, stringBuilder.toString());
   }
 
   @Override

diff --git a/api/src/test/java/io/opentelemetry/trace/propagation/HttpTraceContextTest.java b/api/src/test/java/io/opentelemetry/trace/propagation/HttpTraceContextTest.java
@@ -58,7 +58,7 @@ public class HttpTraceContextTest {
   private static final Setter<Map<String, String>> setter =
       new Setter<Map<String, String>>() {
         @Override
-        public void put(Map<String, String> carrier, String key, String value) {
+        public void set(Map<String, String> carrier, String key, String value) {
           carrier.put(key, value);
         }
       };

diff --git a/opentracing_shim/src/main/java/io/opentelemetry/opentracingshim/Propagation.java b/opentracing_shim/src/main/java/io/opentelemetry/opentracingshim/Propagation.java
@@ -58,7 +58,7 @@ private TextMapSetter() {}
     public static final TextMapSetter INSTANCE = new TextMapSetter();
 
     @Override
-    public void put(TextMapInject carrier, String key, String value) {
+    public void set(TextMapInject carrier, String key, String value) {
       carrier.put(key, value);
     }
   }

diff --git a/...testbed/src/test/java/io/opentelemetry/sdk/contrib/trace/testbed/clientserver/Client.java b/...testbed/src/test/java/io/opentelemetry/sdk/contrib/trace/testbed/clientserver/Client.java
@@ -47,7 +47,7 @@ public void send() throws InterruptedException {
               message,
               new Setter<Message>() {
                 @Override
-                public void put(Message carrier, String key, String value) {
+                public void set(Message carrier, String key, String value) {
                   carrier.put(key, value);
                 }
               });