Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing links to deprecated constants in SemanticAttributes #5406

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Add missing links to deprecated constants in SemanticAttributes #5406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions buildscripts/semantic-convention/templates/SemanticAttributes.java.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,14 @@ public final class {{class}} {

/**
* The name of the transport protocol.
* @deprecated This item has been removed as of 1.17.0 of the semantic conventions. There is no replacement.
* @deprecated This item has been removed as of 1.17.0 of the semantic conventions. Use {@link SemanticAttributes#NET_APP_PROTOCOL_NAME} instead.
*/
@Deprecated
public static final AttributeKey<String> MESSAGING_PROTOCOL = stringKey("messaging.protocol");

/**
* The version of the transport protocol.
* @deprecated This item has been removed as of 1.17.0 of the semantic conventions. There is no replacement.
* @deprecated This item has been removed as of 1.17.0 of the semantic conventions. Use {@link SemanticAttributes#NET_APP_PROTOCOL_VERSION} instead.
*/
@Deprecated
public static final AttributeKey<String> MESSAGING_PROTOCOL_VERSION =
Expand Down
8 changes: 4 additions & 4 deletions semconv/src/main/java/io/opentelemetry/semconv/trace/attributes/SemanticAttributes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1716,17 +1716,17 @@ private RpcConnectRpcErrorCodeValues() {}
/**
* The name of the transport protocol.
*
* @deprecated This item has been removed as of 1.17.0 of the semantic conventions. There is no
* replacement.
* @deprecated This item has been removed as of 1.17.0 of the semantic conventions. Use {@link
* SemanticAttributes#NET_APP_PROTOCOL_NAME} instead.
*/
@Deprecated
public static final AttributeKey<String> MESSAGING_PROTOCOL = stringKey("messaging.protocol");

/**
* The version of the transport protocol.
*
* @deprecated This item has been removed as of 1.17.0 of the semantic conventions. There is no
* replacement.
* @deprecated This item has been removed as of 1.17.0 of the semantic conventions. Use {@link
* SemanticAttributes#NET_APP_PROTOCOL_VERSION} instead.
*/
@Deprecated
public static final AttributeKey<String> MESSAGING_PROTOCOL_VERSION =
Expand Down