Add missing links to deprecated constants in SemanticAttributes #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5406 +/- ##
============================================
- Coverage 91.30% 91.29% -0.02%
+ Complexity 4879 4878 -1
============================================
Files 549 549
Lines 14379 14379
Branches 1354 1354
============================================
- Hits 13129 13127 -2
- Misses 863 864 +1
- Partials 387 388 +1 ☔ View full report in Codecov by Sentry. |
jack-berg
reviewed
Apr 26, 2023
Donnerbart
force-pushed
the
add-missing-links-to-semantic-attributes
branch
from
30af4ba to
1a92eac
Compare
mateuszrzeszutek
approved these changes
Apr 26, 2023
Donnerbart
changed the title
jack-berg
approved these changes
Apr 26, 2023
jkwatson
reviewed
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated semantic convention keys
MESSAGING_PROTOCOLandMESSAGING_PROTOCOL_VERSIONare missing a link to their according replacements. See open-telemetry/opentelemetry-specification#2957If you don't know where to look, it's quite cumbersome to find the spec change PR. In the worst case developers remove their attributes instead of updating correctly.