OpenTracing Shim: Handle unsupported types when setting Attributes. #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens through: * SpanBuilder.withTag() * Span.setTag()
Codecov ReportBase: 90.96% // Head: 91.01% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4939 +/- ##
============================================
+ Coverage 90.96% 91.01% +0.04%
- Complexity 4838 4841 +3
============================================
Files 546 546
Lines 14439 14442 +3
Branches 1395 1395
============================================
+ Hits 13135 13144 +9
+ Misses 901 893 -8
- Partials 403 405 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
approved these changes
Nov 13, 2022
| SpanData spanData = ((ReadableSpan) span.getSpan()).toSpanData(); | ||
| assertThat(spanData.getAttributes().size()).isEqualTo(1); | ||
| assertThat(spanData.getAttributes().get(AttributeKey.stringKey("foo"))) | ||
| .isEqualTo(BigInteger.TEN.toString()); |
There was a problem hiding this comment.
Do you think there's any value in being explicit about the expected string? I.e. .isEqualTo("10")?
There was a problem hiding this comment.
Assertions now compare against literals directly ;)
mateuszrzeszutek
approved these changes
Nov 14, 2022
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java
that referenced
this pull request
Dec 30, 2022
…pen-telemetry#4939) * OpenTracing Shim: Handle unsupported types when setting Attributes. This happens through: * SpanBuilder.withTag() * Span.setTag() * Simplify BigInteger conversion assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4908
This happens via: