Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTracing Shim: Support setting ALL tag/attribute types #4908

Closed
Tracked by #4911
carlosalberto opened this issue Nov 2, 2022 · 0 comments · Fixed by #4939
Closed
Tracked by #4911

OpenTracing Shim: Support setting ALL tag/attribute types #4908

carlosalberto opened this issue Nov 2, 2022 · 0 comments · Fixed by #4939

Comments

@carlosalberto
Copy link
Contributor

Currently setting tags/attributes on Spans only works if the type is fully supported (boolean, long, double, string, etc). As per the Specification, unsupported types must be set using their string representation (i.e. toString() in Java).

See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opentracing.md#set-tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OpenTracing Shim: Handle unsupported types when setting Attributes. carlosalberto/opentelemetry-java
1 participant
@carlosalberto