Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jmxfetch module #13

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Remove jmxfetch module #13

merged 2 commits into from
Nov 19, 2019

Conversation

trask
Copy link
Member

@trask trask commented Nov 15, 2019

Resolves #5

@trask
Copy link
Member Author

trask commented Nov 15, 2019

On second thought, I think probably better to merge dd-master first, then I will re-target this PR to master.

@trask trask changed the base branch from dd-master to master November 17, 2019 18:45
jkwatson
jkwatson approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit d86632d into open-telemetry:master Nov 19, 2019
@trask trask deleted the remove-jmxfetch-module branch November 19, 2019 01:24
bjrara pushed a commit to bjrara/opentelemetry-java-instrumentation that referenced this pull request Nov 27, 2024
@mxiamxia
Merge pull request open-telemetry#13 from yiyuan-he/update-bedrock
170b4c2 
feat: update bedrock resource attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwatson jkwatson jkwatson approved these changes

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

@safris safris Awaiting requested review from safris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove agent-jmxfetch module
2 participants
@trask @jkwatson