Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove agent-jmxfetch module #5

Closed
trask opened this issue Nov 15, 2019 · 0 comments · Fixed by #13
Closed

Remove agent-jmxfetch module #5

trask opened this issue Nov 15, 2019 · 0 comments · Fixed by #13
Milestone
v0.1.0

Comments

@trask
Copy link
Member

trask commented Nov 15, 2019

See agent-jmxfetch.

JMX metrics likely make sense for this project, but this doesn't seem like the best starting point.
@trask trask mentioned this issue Nov 15, 2019
Merged
@trask trask added this to the v0.1.0 milestone Nov 18, 2019
@trask trask closed this as completed in #13 Nov 19, 2019
bmuskalla pushed a commit to bmuskalla/opentelemetry-java-instrumentation that referenced this issue Nov 30, 2020
fix compatibility open-telemetry#5
92c6b05
alesj added a commit to alesj/opentelemetry-java-instrumentation that referenced this issue Sep 30, 2021
@alesj
Apply feedback open-telemetry#5.
bd8a5d5
trask added a commit that referenced this issue Oct 2, 2021
@alesj @trask
Add support for Kafka consumer and producer interceptors. (#4065)
ff0bf0a 
* Add support for Kafka consumer and producer interceptors, move common Kafka code to library module.

* Apply feedback

* Apply feedback, #3.

* Apply feedback, #4.

* Add producer / consumer wrappers.

* Move to kafka-clients-2.6.

* Apply feedback #5.

Co-authored-by: Trask Stalnaker <[email protected]>
siyuniu-ms referenced this issue in siyuniu-ms/opentelemetry-java-instrumentation Jan 24, 2023
@siyuniums
Merge pull request #5 from siyuniums/content_length
a1b42a8 
Content length
bjrara pushed a commit to bjrara/opentelemetry-java-instrumentation that referenced this issue Nov 27, 2024
@mxiamxia
support bedrock and bedrock runtime resources Java SDK V2(open-teleme…
debb9be 
…try#5)

This PR add AWS Bedrock and BedrockRuntime support for AWS Java SDK V2 with the following change:

A. **Bedrock**:
Extract `guardrailId` from API response, and add into `"aws.bedrock.guardrail.id"` span attribute.

B. **Bedrock Agent**:
Extract `agentId` from both API request and response, and add into `"aws.bedrock.agent.id"` span attribute.
Extract `knowledgeBaseId` from API request, and add into `"aws.bedrock.knowledgebase.id"` span attribute.
Extract `dataSourceId` from both API request and response,, and add into `"aws.bedrock.datasource.id"` span attribute.

The instrumentation is on API operation level, we make sure only one attribute is extracted per API call, there will be no overlap/conflict  to identify the resouce.

C. **Bedrock Agent Runtime**:
Extract `agentId` from API request, and add into `"aws.bedrock.agent.id"` span attribute.
Extract `knowledgeBaseId` from API request, and add into `"aws.bedrock.knowledgebase.id"` span attribute.

D. **Bedrock Runtime**:
Extract the following attributes and add into span according to [ Gen AI semantic-conventions](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/attributes-registry/gen-ai.md):

```
gen_ai.request.model
gen_ai.system
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Remove jmxfetch module
1 participant
@trask