Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Muzzle should fail on unimplemented abstract methods #1193

Merged
merged 6 commits into from
Sep 23, 2020
Merged

Muzzle should fail on unimplemented abstract methods #1193

merged 6 commits into from
Sep 23, 2020

Conversation

mateuszrzeszutek
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek commented Sep 11, 2020 •
edited
Loading

Resolves #1123

@trask
Copy link
Member

trask commented Sep 12, 2020

Thank you for tackling this ❤️👍

@mateuszrzeszutek mateuszrzeszutek force-pushed the muzzle2 branch 17 times, most recently from 01e65e2 to 173db14 Compare September 18, 2020 14:58
@mateuszrzeszutek mateuszrzeszutek changed the title [WORK IN PROGRESS] Muzzle should fail on unimplemented abstract methods Muzzle should fail on unimplemented abstract methods Sep 18, 2020
@mateuszrzeszutek mateuszrzeszutek marked this pull request as ready for review September 18, 2020 16:10
@iNikem
Copy link
Contributor

iNikem commented Sep 18, 2020

Hei, @mateuszrzeszutek, maybe you can help @trask with #536 ;)

@trask
Copy link
Member

trask commented Sep 21, 2020

Hei, @mateuszrzeszutek, maybe you can help @trask with #536 ;)

💯

@mateuszrzeszutek I will review this PR tomorrow 👍

@mateuszrzeszutek
Copy link
Member Author

Hei, @mateuszrzeszutek, maybe you can help @trask with #536 ;)

Sure - after implementing this change I think I can answer at least half of these questions. I'll put it on my TODO list and push a PR soon.

trask
trask reviewed Sep 22, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried to see if this would have caught the ServletOutputStream issue? i gave it a try, but muzzle still didn't fail for me on unimplemented ServletOutputStream methods

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/Reference.java Outdated Show resolved Hide resolved
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/Reference.java Show resolved Hide resolved
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcher.java Outdated Show resolved Hide resolved
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcher.java Outdated Show resolved Hide resolved
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcher.java Outdated Show resolved Hide resolved
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceCreator.java Show resolved Hide resolved
@trask
Update javaagent-tooling/src/main/java/io/opentelemetry/javaagent/too…
7df71f3 
…ling/muzzle/Reference.java

Co-authored-by: Trask Stalnaker <[email protected]>
@mateuszrzeszutek
Copy link
Member Author

have you tried to see if this would have caught the ServletOutputStream issue? i gave it a try, but muzzle still didn't fail for me on unimplemented ServletOutputStream methods

You're right, I unknowingly introduced a bug when I was refactoring the first working version. Thanks for noticing it! I'll add a unit test that covers this specific scenario.

trask
trask approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

@iNikem iNikem merged commit 3d03028 into open-telemetry:master Sep 23, 2020
@mateuszrzeszutek mateuszrzeszutek deleted the muzzle2 branch November 18, 2022 10:26
@trask trask mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNikem iNikem iNikem approved these changes

@trask trask trask approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Muzzle should fail on unimplemented abstract methods
3 participants
@mateuszrzeszutek @trask @iNikem