Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muzzle should fail on unimplemented abstract methods #1123

Closed
mateuszrzeszutek opened this issue Aug 28, 2020 · 0 comments · Fixed by #1193
Closed

Muzzle should fail on unimplemented abstract methods #1123

mateuszrzeszutek opened this issue Aug 28, 2020 · 0 comments · Fixed by #1193
Assignees

Comments

@mateuszrzeszutek
Copy link
Member

This is an idea for improvement that would have prevented something like #1083 from happening.
In that issue, Servlet API 3.1 introduced two new abstract methods to ServletOutputStream that were unimplemented in our code -- and everything was OK until someone tried to call one of them.

I believe that muzzle should fail for an instrumentation if one of our classes that implements/extends some lib/framework class has missing methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants