Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround NoClassDefFoundError in @PreDestroy waiting for MNG-7056 #1431

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Workaround NoClassDefFoundError in @PreDestroy waiting for MNG-7056 #1431

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58e9a52
Workaround NoClassDefFoundError in @PreDestroy waiting for MNG-7056
cyrille-leclerc Aug 22, 2024
a33e2c3
Merge branch 'open-telemetry:main' into fix-noclassdeffound-in-predes…
cyrille-leclerc Aug 26, 2024
cddde0b
Merge branch 'main' into fix-noclassdeffound-in-predestroy
cyrille-leclerc Dec 9, 2024
c328b4d
Better docs
cyrille-leclerc Dec 9, 2024
70de93f
Better docs
cyrille-leclerc Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions maven-extension/src/main/java/io/opentelemetry/maven/OtelLifecycleParticipant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ public final class OtelLifecycleParticipant extends AbstractMavenLifecyclePartic

private static final Logger logger = LoggerFactory.getLogger(OtelLifecycleParticipant.class);

private final OpenTelemetrySdkService openTelemetrySdkService;

private final OtelExecutionListener otelExecutionListener;

/**
Expand All @@ -30,6 +32,7 @@ public final class OtelLifecycleParticipant extends AbstractMavenLifecyclePartic
@Inject
OtelLifecycleParticipant(
OpenTelemetrySdkService openTelemetrySdkService, SpanRegistry spanRegistry) {
this.openTelemetrySdkService = openTelemetrySdkService;
this.otelExecutionListener = new OtelExecutionListener(spanRegistry, openTelemetrySdkService);
}

Expand All @@ -56,8 +59,16 @@ public void afterProjectsRead(MavenSession session) {
.setExecutionListener(
new ChainedExecutionListener(this.otelExecutionListener, initialExecutionListener));
logger.debug(
"OpenTelemetry: OpenTelemetry extension registered as execution listener. InitialExecutionListener: "
+ initialExecutionListener);
"OpenTelemetry: OpenTelemetry extension registered as execution listener. InitialExecutionListener: {}",
initialExecutionListener);
}
}

@Override
public void afterSessionEnd(MavenSession session) {
// Workaround https://issues.apache.org/jira/browse/MNG-8217
// close OpenTelemetry SDK in `afterSessionEnd()`
logger.debug("OpenTelemetry: After Maven session end, close OpenTelemetry SDK");
openTelemetrySdkService.close();
}
}
Loading