Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround NoClassDefFoundError in @PreDestroy waiting for MNG-7056 #1431

Merged

Conversation

cyrille-leclerc
Copy link
Member

@cyrille-leclerc cyrille-leclerc commented Aug 22, 2024

Description:

Workaround NoClassDefFoundError in @PreDestroy waiting for MNG-8217 ClassNotFoundException in @PreDestroy method when Maven extension declared in pom.xml

Existing Issue(s):

Testing:

Unfortunately, no testing framework for the lifecycle of Maven extensions

Documentation:

None

Outstanding items:

None

@cyrille-leclerc
Copy link
Member Author

@kenfinnigan could you please have a look?

@cyrille-leclerc cyrille-leclerc requested a review from a team as a code owner December 9, 2024 21:26
@cyrille-leclerc
Copy link
Member Author

@SylvainJuge can I kindly ask you to review this PR? 🙏 Hopefully it's straightforward.

@trask trask added this to the v1.42.0 milestone Dec 9, 2024
Copy link
Contributor

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll trust you on the maven expertise though.

@trask trask merged commit 9cf28ad into open-telemetry:main Dec 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants