-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate instrument names when creating them #4210
Merged
MrAlias
merged 19 commits into
open-telemetry:main
from
dmathieu:validate-instrument-name
Jun 9, 2023
Merged
Validate instrument names when creating them #4210
MrAlias
merged 19 commits into
open-telemetry:main
from
dmathieu:validate-instrument-name
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared and
hanyuancheung
as code owners
June 7, 2023 12:23
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4210 +/- ##
=======================================
- Coverage 83.3% 83.3% -0.1%
=======================================
Files 181 181
Lines 13940 13986 +46
=======================================
+ Hits 11623 11657 +34
- Misses 2096 2102 +6
- Partials 221 227 +6
|
MrAlias
reviewed
Jun 7, 2023
MrAlias
reviewed
Jun 7, 2023
MrAlias
reviewed
Jun 7, 2023
MrAlias
reviewed
Jun 7, 2023
This reverts commit ec8ccc5.
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
MadVikingGod
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validates instrument names when they are created, per the specification.
Closes #4204.