Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the instrument when a Meter creates the instrument #4204

Closed
MrAlias opened this issue Jun 5, 2023 · 0 comments · Fixed by #4210
Closed

Validate the instrument when a Meter creates the instrument #4204

MrAlias opened this issue Jun 5, 2023 · 0 comments · Fixed by #4210
Assignees
@dmathieu
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Milestone
v1.17.0/v0.40.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jun 5, 2023 •
edited by dmathieu
Loading

From the specification:

When a Meter creates an instrument, it SHOULD validate the instrument name conforms to the instrument name syntax

If the instrument name does not conform to this syntax, the Meter SHOULD emit an error notifying the user about the invalid name. It is left unspecified if a valid instrument is also returned.

This is not currently done and needs to be added to the SDK.

Originally posted by @MrAlias in #3654 (comment)
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Jun 5, 2023
@MrAlias MrAlias mentioned this issue Jun 5, 2023
Closed
2 tasks
@dmathieu dmathieu self-assigned this Jun 7, 2023
@dmathieu dmathieu mentioned this issue Jun 7, 2023
Merged
@MrAlias MrAlias moved this from Todo to In Progress in Go: Metric SDK (GA) Jun 8, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Metric SDK (GA) Jun 9, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmathieu dmathieu

Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Go: Metric SDK (GA)
Status: Done
Milestone
v1.17.0/v0.40.0
Development

Successfully merging a pull request may close this issue.

Validate instrument names when creating them
2 participants
@dmathieu @MrAlias