-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.15.0/v0.38.0 #4035
Merged
Merged
Release v1.15.0/v0.38.0 #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
April 27, 2023 21:01
12 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4035 +/- ##
=======================================
- Coverage 82.2% 82.2% -0.1%
=======================================
Files 176 176
Lines 13058 13058
=======================================
- Hits 10742 10740 -2
- Misses 2095 2097 +2
Partials 221 221
|
Aneurysm9
approved these changes
Apr 27, 2023
pellared
approved these changes
Apr 28, 2023
hanyuancheung
approved these changes
Apr 28, 2023
dmathieu
approved these changes
Apr 28, 2023
reenjii
added a commit
to reenjii/opentelemetry-go-extra
that referenced
this pull request
May 2, 2023
The latest opentelemetry-go release v1.15.0/v0.38.0 introduces a breaking change that breaks otelsql. We need to use new metric.WithAttributes helper to build an ObserveOption list from a KeyValue list. > The measurement methods for all instruments in go.opentelemetry.io/otel/metric/instrument accept an option instead of the variadic "go.opentelemetry.io/otel/attribute".KeyValue Latest opentelemetry-go release: open-telemetry/opentelemetry-go#4035 Breaking change: open-telemetry/opentelemetry-go#3971
This was referenced May 2, 2023
reenjii
added a commit
to reenjii/opentelemetry-go-extra
that referenced
this pull request
May 2, 2023
The latest opentelemetry-go release v1.15.0/v0.38.0 introduces a breaking change. > The measurement methods for all instruments in go.opentelemetry.io/otel/metric/instrument > accept an option instead of the variadic "go.opentelemetry.io/otel/attribute".KeyValue It breaks otelsql: we need to use new metric.WithAttributes helper to build an ObserveOption list from a KeyValue list. Latest opentelemetry-go release: open-telemetry/opentelemetry-go#4035 Breaking change: open-telemetry/opentelemetry-go#3971
reenjii
added a commit
to reenjii/opentelemetry-go-extra
that referenced
this pull request
May 3, 2023
The latest opentelemetry-go release v1.15.0/v0.38.0 introduces a breaking change. > The measurement methods for all instruments in go.opentelemetry.io/otel/metric/instrument > accept an option instead of the variadic "go.opentelemetry.io/otel/attribute".KeyValue It breaks otelsql: we need to use new metric.WithAttributes helper to build an ObserveOption list from a KeyValue list. Latest opentelemetry-go release: open-telemetry/opentelemetry-go#4035 Breaking change: open-telemetry/opentelemetry-go#3971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
go.opentelemetry.io/otel/metric/embedded
package. (Add embedded private method interfaces in metric API #3916)Version
function togo.opentelemetry.io/otel/sdk
to return the SDK version. (Add Version func to otel/sdk #3949)WithNamespace
option togo.opentelemetry.io/otel/exporters/prometheus
to allow users to prefix metrics with a namespace. (prometheus: add WithNamespace option to prefix metrics #3970)go.opentelemetry.io/otel/metric/instrument
to be used in the configuration of measurement methods. (Add options to measurement methods #3971)AddConfig
used to hold configuration for addition measurementsNewAddConfig
used to create a newAddConfig
AddOption
used to configure anAddConfig
RecordConfig
used to hold configuration for recorded measurementsNewRecordConfig
used to create a newRecordConfig
RecordOption
used to configure aRecordConfig
ObserveConfig
used to hold configuration for observed measurementsNewObserveConfig
used to create a newObserveConfig
ObserveOption
used to configure anObserveConfig
WithAttributeSet
andWithAttributes
are added togo.opentelemetry.io/otel/metric/instrument
. They return an option used during a measurement that defines the attribute Set associated with the measurement. (Add options to measurement methods #3971)Version
function togo.opentelemetry.io/otel/exporters/otlp/otlpmetric
to return the OTLP metrics client version. (Add Version func to otlpmetric and otlptrace #3956)Version
function togo.opentelemetry.io/otel/exporters/otlp/otlptrace
to return the OTLP trace client version. (Add Version func to otlpmetric and otlptrace #3956)Changed
Extrema
ingo.opentelemetry.io/otel/sdk/metric/metricdata
is redefined with a generic argument of[N int64 | float64]
. (Update Histogram Extrema and Sum to be generic #3870)go.opentelemetry.io/otel/metric
to embed their corresponding interface fromgo.opentelemetry.io/otel/metric/embedded
. This adds an implementation requirement to set the interface default behavior for unimplemented methods. (Add embedded private method interfaces in metric API #3916)go.opentelemetry.io/otel/metric
into its own packagego.opentelemetry.io/otel/metric/noop
. (Move metric No-Op tometric/noop
#3941)metric.NewNoopMeterProvider
is replaced withnoop.NewMeterProvider
"go.opentelemetry.io/otel/trace".SpanContext
tobridgeSpanContext
by embeddingotel.SpanContext
inbridgeSpanContext
. (Added methods for SpanID and TraceID on bridgeSpanContext #3966)UploadMetrics
error ingo.opentelemetry.io/otel/exporters/otlp/otlpmetric/
to improve error message when encountering generic grpc errors. ([exporters/otlp/otlpmetric] Wrap upload metrics error to provide additional context #3974)go.opentelemetry.io/otel/metric/instrument
accept an option instead of the variadic"go.opentelemetry.io/otel/attribute".KeyValue
. (Add options to measurement methods #3971)Int64Counter.Add
method now accepts...AddOption
Float64Counter.Add
method now accepts...AddOption
Int64UpDownCounter.Add
method now accepts...AddOption
Float64UpDownCounter.Add
method now accepts...AddOption
Int64Histogram.Record
method now accepts...RecordOption
Float64Histogram.Record
method now accepts...RecordOption
Int64Observer.Observe
method now accepts...ObserveOption
Float64Observer.Observe
method now accepts...ObserveOption
Observer
methods ingo.opentelemetry.io/otel/metric
accept an option instead of the variadic"go.opentelemetry.io/otel/attribute".KeyValue
. (Add options to measurement methods #3971)Observer.ObserveInt64
method now accepts...ObserveOption
Observer.ObserveFloat64
method now accepts...ObserveOption
go.opentelemetry.io/otel/metric/global
fromgo.opentelemetry.io/otel
. (Move global metric back tootel/metric/global
for minor release #3986)Fixed
TracerProvider
allows callingTracer()
while it's shutting down. It used to deadlock. (TracerProvider allows calling Tracer() while it's shutting down #3924)go.opentelemetry.io/otel/sdk/resource
. (Add Version func to otel/sdk #3949)SpanProcessor
returned byNewSimpleSpanProcessor
ingo.opentelemetry.io/otel/sdk/trace
. (Fixed race condition in OnEnd and added a unit test #3951)aggregation.Default
. (Fix aggregation.Default to properly return the default one #3967)Deprecated
go.opentelemetry.io/otel/metric/instrument
package is deprecated. Use the equivalent types added togo.opentelemetry.io/otel/metric
instead. (Unify metric API into the oneotel/metric
package #4018)