-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Version func to otlpmetric and otlptrace #3956
Merged
MrAlias
merged 15 commits into
open-telemetry:main
from
remychantenay:exporters-versions
Apr 10, 2023
Merged
Add Version func to otlpmetric and otlptrace #3956
MrAlias
merged 15 commits into
open-telemetry:main
from
remychantenay:exporters-versions
Apr 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remychantenay
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
March 31, 2023 18:07
remychantenay
commented
Mar 31, 2023
MrAlias
reviewed
Apr 1, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3956 +/- ##
=======================================
- Coverage 82.0% 82.0% -0.1%
=======================================
Files 171 174 +3
Lines 12969 12975 +6
=======================================
+ Hits 10647 10651 +4
- Misses 2102 2104 +2
Partials 220 220
|
MrAlias
approved these changes
Apr 4, 2023
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Apr 6, 2023
hanyuancheung
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3946
Currently the SDK resources report the SDK version as the API version. If a project uses a different version of the SDK than the API this information will be incorrect. Add a version function to the SDK and use it.
Note: Part of the issue was fixed in #3949
PS: this is my very first contribution, please be gentle 🙏 😉