sdk/resource: honor OTEL_SERVICE_NAME in fromEnv resource detector #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
requested review from
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo and
XSAM
as code owners
Signed-off-by: Anthony J Mirabella <[email protected]>
Aneurysm9
added
area:resources
Codecov Report
@@ Coverage Diff @@
## main #1969 +/- ##
=====================================
Coverage 76.3% 76.3%
=====================================
Files 157 157
Lines 8358 8363 +5
=====================================
+ Hits 6380 6385 +5
Misses 1723 1723
Partials 255 255
|
Signed-off-by: Anthony J Mirabella <[email protected]>
MrAlias
approved these changes
Jun 3, 2021
dashpole
approved these changes
Jun 4, 2021
MrAlias
reviewed
Jun 4, 2021
Signed-off-by: Anthony J Mirabella <[email protected]>
evantorrie
approved these changes
Jun 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1968