Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Resource service.name detection from OTEL_SERVICE_NAME environment variable #1968

Closed
evantorrie opened this issue Jun 3, 2021 · 0 comments · Fixed by #1969
Closed

Enable Resource service.name detection from OTEL_SERVICE_NAME environment variable #1968

evantorrie opened this issue Jun 3, 2021 · 0 comments · Fixed by #1969
Assignees
@Aneurysm9
Labels
bug Something isn't working
Milestone
RC1

Comments

@evantorrie
Copy link
Contributor

evantorrie commented Jun 3, 2021 •
edited
Loading

Description

Recent change in the specification has added a way to explicitly set the service.name attribute of the Resource via the OTEL_SERVICE_NAME environment variable. This should override any service.name attribute in OTEL_RESOURCE_ATTRIBUTES.

Environment

  • OS: All
  • Architecture: All
  • Go Version: All
  • opentelemetry-go version: v0.20.0

Steps To Reproduce

  1. Set the environment variable OTEL_SERVICE_NAME to foo
  2. Start an OpenTelemetry enabled process which outputs the Resource attributes.

Expected behavior

The Resource's service.name attribute should be foo rather than unknown_service.
@evantorrie evantorrie added the bug Something isn't working label Jun 3, 2021
@MrAlias MrAlias added this to the RC1 milestone Jun 3, 2021
@Aneurysm9 Aneurysm9 self-assigned this Jun 3, 2021
@Aneurysm9 Aneurysm9 mentioned this issue Jun 3, 2021
Merged
@pellared pellared moved this to Closed in Go: Triage Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aneurysm9 Aneurysm9

Labels
bug Something isn't working
Projects
Go: Triage
Archived in project
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

sdk/resource: honor OTEL_SERVICE_NAME in fromEnv resource detector Aneurysm9/opentelemetry-go
3 participants
@Aneurysm9 @MrAlias @evantorrie