Add sampling config for instrumentation #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
changed the title
damemi
reviewed
Aug 8, 2024
edeNFed
approved these changes
Aug 12, 2024
MrAlias
reviewed
Aug 19, 2024
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
reviewed
Aug 20, 2024
damemi
reviewed
Aug 21, 2024
MrAlias
reviewed
Aug 21, 2024
Co-authored-by: Mike Dame <[email protected]>
MrAlias
reviewed
Aug 28, 2024
MrAlias
approved these changes
Sep 5, 2024
|
|
minimAluminiumalism
pushed a commit
to minimAluminiumalism/opentelemetry-go-instrumentation
that referenced
this pull request
Sep 9, 2024
* Add sampling config for instrumetnation * changelog * Apply suggestions from code review Co-authored-by: Tyler Yahn <[email protected]> * Update sampling.go Co-authored-by: Tyler Yahn <[email protected]> * Update internal/pkg/instrumentation/probe/sampling/sampling.go Co-authored-by: Tyler Yahn <[email protected]> * fix typo in function name * remove unnecessery function * code review changes * Add test for invalid sampler config * Adjust probe load test * update samplingRateDenominator to math.MaxUint32 * Update config/sampling.go Co-authored-by: Mike Dame <[email protected]> * code review fix --------- Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Mike Dame <[email protected]>
MrAlias
added a commit
to MrAlias/opentelemetry-go-instrumentation
that referenced
this pull request
Sep 18, 2024
* Add sampling config for instrumetnation * changelog * Apply suggestions from code review Co-authored-by: Tyler Yahn <[email protected]> * Update sampling.go Co-authored-by: Tyler Yahn <[email protected]> * Update internal/pkg/instrumentation/probe/sampling/sampling.go Co-authored-by: Tyler Yahn <[email protected]> * fix typo in function name * remove unnecessery function * code review changes * Add test for invalid sampler config * Adjust probe load test * update samplingRateDenominator to math.MaxUint32 * Update config/sampling.go Co-authored-by: Mike Dame <[email protected]> * code review fix --------- Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Mike Dame <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the high-level code handling the sampling configuration.