Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling support #953

Open
6 of 7 tasks
RonFed opened this issue Jul 16, 2024 · 0 comments
Open
6 of 7 tasks

Sampling support #953

RonFed opened this issue Jul 16, 2024 · 0 comments
Assignees

Comments

@RonFed
Copy link
Contributor

RonFed commented Jul 16, 2024

This issue will track the development of sampling support.
As discussed in the SIG, the reason the sampling logic should be included in the eBPF code is that the span is created in eBPF, and so is the span context which contains the trace flags. The trace flags should be propagated to the child spans in the same process. Hence, sampling in Go code might be too late and won't reflect the sampling correctly. This behavior is described in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant