Initial support for Trace-flags #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to add support for the trace-flags field in span context, specifically the sampled flag.
The current state is that we are not checking this flag. For example we can create an HTTP server span without any visible parent (since the parent in some remote service was configured to not sample), this change will avoid passing the HTTP server from the probe to user space if the sampled flag is off.
Introduce 2 functions which are commonly used and will reduce duplication between the probes:
Currently, I added the check for
is_sampledonly in the http server probe, and plan to add it in the other probes in a future PR.