otelgrpc: Remove high cardinality metric attributes

[MadVikingGod]

Related to #3536
Closes #3071

This removes Peer attributes from grpc.

[dmathieu]

Should the attributes being emitted be tested?

[codecov]

Codecov Report

Merging #4322 (53ba6bd) into main (2a5fe23) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main   #4322   +/-   ##
=====================================
  Coverage   80.8%   80.8%           
=====================================
  Files        150     150           
  Lines      10366   10367    +1     
=====================================
+ Hits        8382    8383    +1     
  Misses      1840    1840           
  Partials     144     144           

Files	Coverage Δ
...ion/google.golang.org/grpc/otelgrpc/interceptor.go	87.8% <100.0%> (+<0.1%)	⬆️

[pellared]

Should the attributes being emitted be tested?

IMO they should be tested. Example assertion for otelhttp:

opentelemetry-go-contrib/instrumentation/net/http/otelhttp/test/handler_test.go

Line 44 in bf86b26

func assertScopeMetrics(t *testing.T, sm metricdata.ScopeMetrics, attrs attribute.Set) {

PS. Now we also have metricdatatest.IgnoreValue 😉

We should add assertion for the metric attributes.

[MadVikingGod]

Should the attributes being emitted be tested?

I'm of two minds on that. There should be something that lets us know if we are emitting the attributes that are appropriate for the current semver, but not so coupled that updating to the next breaks everything.

e.g. metrics emits all of metrics attributes, and traces emits rpc.grpc, and rpc.server and maybe also rpc. But we also wouldn't want these tests to break just because we updated to the next semantic convention, that would be toil.

That being said there weren't tests of what was produced prior, and I would have updated them if there were.

[pellared]

But we also wouldn't want these tests to break just because we updated to the next semantic convention, that would be toil.

On the other hand, it is double-checking (validating) the changes.
EDIT: Bumping semver is not only about changing the package but e.g. also about adding/removing the set of attributes, sometimes changing their values (hopefully almost never).

[pellared]

Approving as #4323 is created and added to the next release milestone.

[puckpuck]

Any updates on when this is going to get merged and released?