Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][githubgen] Fix code owner whitespace issues #664

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

crobert-1
Copy link
Member

Context

Distributions of the collector can have additional maintainers than the contrib approvers group. This means optionally there need to be trailing spaces. This change accounts for this use-case.

@crobert-1 crobert-1 requested review from a team as code owners January 17, 2025 19:05
@crobert-1 crobert-1 requested a review from jpkrohling January 17, 2025 19:05
@crobert-1 crobert-1 marked this pull request as draft January 17, 2025 19:08
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 48.83%. Comparing base (90c9b09) to head (42a3e0d).

Files with missing lines Patch % Lines
githubgen/codeowners.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   48.89%   48.83%   -0.06%     
==========================================
  Files          57       57              
  Lines        3383     3387       +4     
==========================================
  Hits         1654     1654              
- Misses       1568     1572       +4     
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants