-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][CODEOWNERS] Remove trailing whitespace #37293
Conversation
See #37294 ; please consider opening the same PR against opentelemetry-go-build-tools so we don't have regressions when we switch over. |
I've opened open-telemetry/opentelemetry-go-build-tools#663 to make this change in the other repo as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37293 +/- ##
=======================================
Coverage 79.57% 79.58%
=======================================
Files 2274 2274
Lines 212986 212986
=======================================
+ Hits 169493 169513 +20
+ Misses 37801 37785 -16
+ Partials 5692 5688 -4 ☔ View full report in Codecov by Sentry. |
I think the The action checks out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix this one as well:
codeowners += fmt.Sprintf("reports/distributions/%s.yaml%s @open-telemetry/collector-contrib-approvers %s\n", dist.Name, strings.Repeat(" ", longestName-len(dist.Name)), strings.Join(maintainers, " ")) |
6f2176a
to
8d06d5c
Compare
Done. I've opened open-telemetry/opentelemetry-go-build-tools#664 as well to address this. |
We have to let this PR in, and then see if main passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crobert-1 !
and it's looking good on mainline: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12836111736/job/35797060442 |
Description
githubgen
was adding trailing whitespaces to unmaintained components that was unnecessary. This removes the trailing whitespaces.Link to tracking issue
Fixes #37292