Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][CODEOWNERS] Remove trailing whitespace #37293

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

crobert-1
Copy link
Member

Description

githubgen was adding trailing whitespaces to unmaintained components that was unnecessary. This removes the trailing whitespaces.

Link to tracking issue

Fixes #37292

@atoulme
Copy link
Contributor

atoulme commented Jan 17, 2025

See #37294 ; please consider opening the same PR against opentelemetry-go-build-tools so we don't have regressions when we switch over.

@crobert-1 crobert-1 closed this Jan 17, 2025
@crobert-1 crobert-1 reopened this Jan 17, 2025
@crobert-1
Copy link
Member Author

See #37294 ; please consider opening the same PR against opentelemetry-go-build-tools so we don't have regressions when we switch over.

I've opened open-telemetry/opentelemetry-go-build-tools#663 to make this change in the other repo as well.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.58%. Comparing base (fa1e76b) to head (6f2176a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #37293   +/-   ##
=======================================
  Coverage   79.57%   79.58%           
=======================================
  Files        2274     2274           
  Lines      212986   212986           
=======================================
+ Hits       169493   169513   +20     
+ Misses      37801    37785   -16     
+ Partials     5692     5688    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crobert-1
Copy link
Member Author

I think the check-codeowners action is failing because it's running the comparison using githubgen built on main.

The action checks out main, runs make githubgen-install, then checks out this branch and runs the already built githubgen against this PR. Since this PR modifies githubgen, the output doesn't match.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix this one as well:

codeowners += fmt.Sprintf("reports/distributions/%s.yaml%s @open-telemetry/collector-contrib-approvers %s\n", dist.Name, strings.Repeat(" ", longestName-len(dist.Name)), strings.Join(maintainers, " "))

@crobert-1
Copy link
Member Author

Could you fix this one as well:

codeowners += fmt.Sprintf("reports/distributions/%s.yaml%s @open-telemetry/collector-contrib-approvers %s\n", dist.Name, strings.Repeat(" ", longestName-len(dist.Name)), strings.Join(maintainers, " "))

Done. I've opened open-telemetry/opentelemetry-go-build-tools#664 as well to address this.

@atoulme
Copy link
Contributor

atoulme commented Jan 17, 2025

We have to let this PR in, and then see if main passes.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crobert-1 !

@songy23 songy23 merged commit f28dfd9 into open-telemetry:main Jan 17, 2025
163 of 164 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 17, 2025
@songy23
Copy link
Member

songy23 commented Jan 17, 2025

and it's looking good on mainline: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12836111736/job/35797060442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI/CD] fix githubgen to not add whitespace after these lines.
4 participants