Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests: add test that loads all maps and programs #205

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

florianl
Copy link
Contributor

initializeMapsAndPrograms() provides core functionality in sizing and loading eBPF maps and programs. So far per-kernel tests only load specific named eBPF programs and therefore could not catch Linux kernel version specific issues with eBPF programs that were not loaded.

@florianl florianl requested review from a team as code owners October 25, 2024 06:00
fabled added a commit to fabled/opentelemetry-ebpf-profiler that referenced this pull request Oct 25, 2024
As a follow up to open-telemetry#142, it was discovered that the clang generated
code is still not fully compliant with all supporter kernel verifiers,
and this will be caught in future with PR open-telemetry#205.

Simplify and rearrange the code sequence so that clang chooses
to generate code that is more verifier compliant.
@florianl florianl force-pushed the flo-integration-test-load-all branch from 444ef5d to 7313c33 Compare October 25, 2024 07:40
@florianl
Copy link
Contributor Author

Rebased this PR on top of #206

initializeMapsAndPrograms() provides core functionality in sizing and
loading eBPF maps and programs. So far per-kernel tests only load specific
named eBPF programs and therefore could not catch Linux kernel version
specific issues with eBPF programs that were not loaded.

Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl force-pushed the flo-integration-test-load-all branch from 93960e5 to d44b609 Compare October 25, 2024 15:16
@florianl
Copy link
Contributor Author

rebased PR on main as #206 got merged

Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

tracer/tracer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fabled fabled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@florianl florianl merged commit 07449f3 into main Oct 28, 2024
23 checks passed
@florianl florianl deleted the flo-integration-test-load-all branch October 28, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants