BPF: dotnet: make nibble map reading more compliant #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the non-obvious reading past end-of-array to next member, and add modulo arithmetic to ensure that bpf verifier is happy. fixes open-telemetry#141
florianl
approved these changes
Aug 30, 2024
florianl
pushed a commit
to florianl/opentelemetry-ebpf-profiler
that referenced
this pull request
Aug 30, 2024
Remove the non-obvious reading past end-of-array to next member, and add modulo arithmetic to ensure that bpf verifier is happy. fixes open-telemetry#141
fabled
added a commit
to fabled/opentelemetry-ebpf-profiler
that referenced
this pull request
Oct 25, 2024
As a follow up to open-telemetry#142, it was discovered that the clang generated code is still not fully compliant with all supporter kernel verifiers, and this will be caught in future with PR open-telemetry#205. Simplify and rearrange the code sequence so that clang chooses to generate code that is more verifier compliant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the non-obvious reading past end-of-array to next member, and add modulo arithmetic to ensure that bpf verifier is happy.
fixes #141